Feedback for code examples

MEN Technology & Media 9 months ago updated by Alexander Shvets 9 months ago 1


Thank you for your great work. 

In the last point I have to guess what you have done with the two methods -- getSeasonalDiscount() and getFees() -- , that you have probably moved inside the discountPrice() method. Those methods are still referring to "$this", so what if those methods are dependent of some data belonging to $this? 

An experienced programmer would probably understand it instantly, but someone who's just starting out does not. 

This sheet does it excellently.

I hope to see some changes in the sheets. Thank you a lot for making this course!



Thanks a lot for your elaborate feedback. I'll add this all to my todo list for the second edition of the course.