Feedback for code examples
Melvin Tehubijuluw 3 years ago • updated by anonymous 3 years ago • 1
Thank you for your great work.
- I do have some feedback. I often see the same coding examples for different problems. It would be nice to have some variety in the examples given. For example: https://refactoring.guru/u/home/slides/data-clumps/7/, I have seen this one atleast 3 times. And there are more examples that are repeated.
- Sometimes you only display a class diagram, which in my opinion makes it harder to grasp what you are trying to explain. A class diagram with a code example would make things easier to understand. For example: https://refactoring.guru/u/home/slides/primitive-obsession/12/
- Sometimes you omit bits and pieces of the code (for sake of simplicity, I guess) but in some examples it would be just guessing what the code should look like. Some concrete code examples, would be really nice. For example: https://refactoring.guru/u/home/slides/long-parameter-list/5/
In the last point I have to guess what you have done with the two methods -- getSeasonalDiscount() and getFees() -- , that you have probably moved inside the discountPrice() method. Those methods are still referring to "$this", so what if those methods are dependent of some data belonging to $this?
An experienced programmer would probably understand it instantly, but someone who's just starting out does not.
I hope to see some changes in the sheets. Thank you a lot for making this course!
Customer support service by UserEcho
Thanks a lot for your elaborate feedback. I'll add this all to my todo list for the second edition of the course.